Similarly, in queue_wb_lat_store we may need to hold this mutex only while we invoke wbt_set_min_lat. And I just realized that in queue_wb_lat_show we need to replace q->elevator_lock with disk->rqos_state_mutex. I have attached the above change for your reference. You may address this in your next patch. Thanks, --Nilay --------------GfeCCR9rVbh37mSeacAOVs4h Content-Type: text/x-patch; charset=UTF-8; name="wbt.patch" Content-Disposition: attachment; filename="wbt.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2Jsb2NrL2Jsay1zeXNmcy5jIGIvYmxvY2svYmxrLXN5c2ZzLmMKaW5k ZXggZmFmZTllOWU5N2NjLi4wMjQ4ZGM5NDM4YzMgMTAwNjQ0Ci0tLSBhL2Jsb2NrL2Jsay1z eXNmcy5jCisrKyBiL2Jsb2NrL2Jsay1zeXNmcy5jCkBAIC01NjAsNyArNTYwLDcgQEAgc3Rh dGljIHNzaXplX3QgcXVldWVfd2JfbGF0X3Nob3coc3RydWN0IGdlbmRpc2sgKmRpc2ssIGNo YXIgKnBhZ2UpCiAJc3NpemVfdCByZXQ7CiAJc3RydWN0IHJlcXVlc3RfcXVldWUgKnEgPSBk aXNrLT5xdWV1ZTsKIAotCW11dGV4X2xvY2soJnEtPmVsZXZhdG9yX2xvY2spOworCW11dGV4 X2xvY2soJmRpc2stPnJxb3Nfc3RhdGVfbXV0ZXgpOwogCWlmICghd2J0X3JxX3FvcyhxKSkg ewogCQlyZXQgPSAtRUlOVkFMOwogCQlnb3RvIG91dDsKQEAgLTU3Myw3ICs1NzMsNyBAQCBz dGF0aWMgc3NpemVfdCBxdWV1ZV93Yl9sYXRfc2hvdyhzdHJ1Y3QgZ2VuZGlzayAqZGlzaywg Y2hhciAqcGFnZSkKIAogCXJldCA9IHN5c2ZzX2VtaXQocGFnZSwgIiVsbHVcbiIsIGRpdl91 NjQod2J0X2dldF9taW5fbGF0KHEpLCAxMDAwKSk7CiBvdXQ6Ci0JbXV0ZXhfdW5sb2NrKCZx LT5lbGV2YXRvcl9sb2NrKTsKKwltdXRleF91bmxvY2soJmRpc2stPnJxb3Nfc3RhdGVfbXV0 ZXgpOwogCXJldHVybiByZXQ7CiB9CiAKQEAgLTU5Myw3ICs1OTMsNiBAQCBzdGF0aWMgc3Np emVfdCBxdWV1ZV93Yl9sYXRfc3RvcmUoc3RydWN0IGdlbmRpc2sgKmRpc2ssIGNvbnN0IGNo YXIgKnBhZ2UsCiAJCXJldHVybiAtRUlOVkFMOwogCiAJbWVtZmxhZ3MgPSBibGtfbXFfZnJl ZXplX3F1ZXVlKHEpOwotCW11dGV4X2xvY2soJmRpc2stPnJxb3Nfc3RhdGVfbXV0ZXgpOwog CiAJcnFvcyA9IHdidF9ycV9xb3MocSk7CiAJaWYgKCFycW9zKSB7CkBAIC02MTgsMTEgKzYx NywxMiBAQCBzdGF0aWMgc3NpemVfdCBxdWV1ZV93Yl9sYXRfc3RvcmUoc3RydWN0IGdlbmRp c2sgKmRpc2ssIGNvbnN0IGNoYXIgKnBhZ2UsCiAJICovCiAJYmxrX21xX3F1aWVzY2VfcXVl dWUocSk7CiAKKwltdXRleF9sb2NrKCZkaXNrLT5ycW9zX3N0YXRlX211dGV4KTsKIAl3YnRf c2V0X21pbl9sYXQocSwgdmFsKTsKKwltdXRleF91bmxvY2soJmRpc2stPnJxb3Nfc3RhdGVf bXV0ZXgpOwogCiAJYmxrX21xX3VucXVpZXNjZV9xdWV1ZShxKTsKIG91dDoKLQltdXRleF91 bmxvY2soJmRpc2stPnJxb3Nfc3RhdGVfbXV0ZXgpOwogCWJsa19tcV91bmZyZWV6ZV9xdWV1 ZShxLCBtZW1mbGFncyk7CiAKIAlyZXR1cm4gcmV0OwpkaWZmIC0tZ2l0IGEvYmxvY2svYmxr LXdidC5jIGIvYmxvY2svYmxrLXdidC5jCmluZGV4IGM4NTg4YmFlMWMxYi4uNzRhZTcxMzFh ZGE5IDEwMDY0NAotLS0gYS9ibG9jay9ibGstd2J0LmMKKysrIGIvYmxvY2svYmxrLXdidC5j CkBAIC03MTQsMTcgKzcxNCwxNyBAQCB2b2lkIHdidF9lbmFibGVfZGVmYXVsdChzdHJ1Y3Qg Z2VuZGlzayAqZGlzaykKIAlpZiAocnFvcykgewogCQlpZiAoZW5hYmxlICYmIFJRV0IocnFv cyktPmVuYWJsZV9zdGF0ZSA9PSBXQlRfU1RBVEVfT0ZGX0RFRkFVTFQpCiAJCQlSUVdCKHJx b3MpLT5lbmFibGVfc3RhdGUgPSBXQlRfU1RBVEVfT05fREVGQVVMVDsKLQkJZ290byB1bmxv Y2s7CisJCW11dGV4X3VubG9jaygmZGlzay0+cnFvc19zdGF0ZV9tdXRleCk7CisJCXJldHVy bjsKIAl9CisJbXV0ZXhfdW5sb2NrKCZkaXNrLT5ycW9zX3N0YXRlX211dGV4KTsKIAogCS8q IFF1ZXVlIG5vdCByZWdpc3RlcmVkPyBNYXliZSBzaHV0dGluZyBkb3duLi4uICovCiAJaWYg KCFibGtfcXVldWVfcmVnaXN0ZXJlZChxKSkKLQkJZ290byB1bmxvY2s7CisJCXJldHVybjsK IAogCWlmIChxdWV1ZV9pc19tcShxKSAmJiBlbmFibGUpCiAJCXdidF9pbml0KGRpc2spOwot dW5sb2NrOgotCW11dGV4X3VubG9jaygmZGlzay0+cnFvc19zdGF0ZV9tdXRleCk7CiB9CiBF WFBPUlRfU1lNQk9MX0dQTCh3YnRfZW5hYmxlX2RlZmF1bHQpOwogCg== --------------GfeCCR9rVbh37mSeacAOVs4h--