Ever since commit eca2040972b4("scsi: block: ioprio: Clean up interface
definition"), the io priority level is masked and can no longer be larger
than IOPRIO_NR_LEVELS so remove this now useless test.
The actual test of io prio level is done in ioprio_value() where any
invalid input of class/level/hint will result in an invalid class being
passed to the syscall, this is introduced in commit 01584c1e2337("scsi:
block: Improve ioprio value validity checks").
Reported-by: Kexin Wei <ys.weikexin@xxxxxxx>
Cc: Damien Le Moal <dlemoal@xxxxxxxxxx>
Signed-off-by: Aaron Lu <ziqianlu@xxxxxxxxxxxxx>
---
Kexin reported a LTP/ioprio_set03 case failure, where the test would
pass IOPRIO_CLASS_BE with priority level 8 and see if kernel would
return error. Turned out she is using an old kernel header where the
change introduced in commit 01584c1e2337("scsi: block: Improve ioprio
value validity checks") isn't available. During troubleshooting, I find
this priority level test confusing and misleading so I think it should
be removed.
block/ioprio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/block/ioprio.c b/block/ioprio.c
index 73301a261429f..60364d3faf800 100644
--- a/block/ioprio.c
+++ b/block/ioprio.c
@@ -46,11 +46,8 @@ int ioprio_check_cap(int ioprio)
*/
if (!capable(CAP_SYS_ADMIN) && !capable(CAP_SYS_NICE))
return -EPERM;
- fallthrough;
- /* rt has prio field too */
+ break;
case IOPRIO_CLASS_BE:
- if (level >= IOPRIO_NR_LEVELS)
- return -EINVAL;
break;
case IOPRIO_CLASS_IDLE:
break;
--
2.39.5
