Hi Russell, Andrew, On Sat, 26 Jul 2025 23:24:36 +0200 Andrew Lunn <andrew@xxxxxxx> wrote: > > - if (iface == PHY_INTERFACE_MODE_SGMII) > > - dev_warn(&phydev->mdio.dev, "module may not function if 1000Base-X not supported\n"); > > I think we need to keep this warning. I don't remember the details, > but i think this is the kernel saying the hardware is broken, this > might not work, we will give it a go, but don't blame me if it does > not work. We need to keep this disclaimer. As I'm preparing for the next iteration, I was wondering if this could be something we could move into the core. The series generalizes most of the SFP handling for PHYs, and I actually don't have a nice spot in at803x to put the warning anymore :) However what's being said by this warning has nothing specific to at803x, it applies to any PHY driver (or even, any SFP upstream) that supports 1000BaseX but does not support SGMII. The idea is that some modules with a built-in PHY will work when using 1000BaseX as the MII (with of course the limitation that 10/100M won't ever work), so instead of bailing out when we have an SGMII module on a 1000BaseX SFP cage, we give it a try with a very loud warning that this is "best effort, probably won't work, don't blame the kernel". This has been discussed a bit originally here [1] Is it OK for you if we move that warning into core code ? Maxime [1] : https://lore.kernel.org/netdev/20210701231253.GM22278@xxxxxxxxxxxxxxxxxxxxx/
