Re: [PATCH v2 1/1] man2/mount.2: expand and clarify docs for MS_REMOUNT | MS_BIND

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Askar,

On Tue, Aug 26, 2025 at 12:37:17PM +0400, Askar Safin wrote:
>  ---- On Mon, 25 Aug 2025 23:13:05 +0400  Alejandro Colomar <alx@xxxxxxxxxx> wrote --- 
>  > Should we say "mount point" instead?  Otherwise, it's inconsistent with
> 
> d-user@comp:/rbt/man-pages$ grep -E -r -I -i 'mount point' /rbt/man-pages/man | wc -l
> 101
> d-user@comp:/rbt/man-pages$ grep -E -r -I -i 'mount-point' /rbt/man-pages/man | wc -l
> 9
> d-user@comp:/rbt/man-pages$ grep -E -r -I -i 'mountpoint' /rbt/man-pages/man | wc -l
> 4
> 
> My experiments show that "mount point" is indeed the most popular variant.
> 
> I changed all "mountpoint" to "mount point".
> 
> I decided to keep all "per-mount-point".

Thanks!

>  > > +have its existing per-mount-point flags
>  > > +cleared and replaced with those in
>  > > +.I mountflags
>  > > +when
>  > > +.B MS_REMOUNT
>  > > +and
>  > > +.B MS_BIND
>  > > +are specified.
>  > 
>  > Maybe reverse the sentence to start with this?
> 
> I decided simply to remove that "MS_REMOUNT and MS_BIND" part
> (because it is already present in previous sentence).

Okay.

>  > > +This means that if
>  > 
>  > I would move the 'if' to the next line.
> 
> I moved it. But, please, next time do it youself.
> I don't plan to become regular man-pages contributor.

I do these small things myself if they're the only issue.  If there are
more important issues, I _also_ point these out, just because it's
useful.

In general, when writing documentation sentences, write them similarly
to how you would write them if they were code.  You never put an if at
the end of a line of code; never put it at the end of a line of
documentation text.

> I addressed all complains except for listed above and sent v3.

I'll check.


Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux