Hi James, On 9/10/25 21:42, James Morse wrote: > In acpi_count_levels(), the initial value of *levels passed by the > caller is really an implementation detail of acpi_count_levels(), so it > is unreasonable to expect the callers of this function to know what to > pass in for this parameter. The only sensible initial value is 0, > which is what the only upstream caller (acpi_get_cache_info()) passes. > > Use a local variable for the starting cache level in acpi_count_levels(), > and pass the result back to the caller via the function return value. > > Gid rid of the levels parameter, which has no remaining purpose. Nit: s/Gid/Get/ > > Fix acpi_get_cache_info() to match. > > Suggested-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx> > Signed-off-by: James Morse <james.morse@xxxxxxx> > Reviewed-by: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx> > --- Thanks, Ben
