On Mon, Jun 02, 2025 at 10:02:15AM -0700, Luck, Tony wrote:
> The actual structure passed to BIOS is the same each time. Just the
> set_error_type_with_address::einjv2_struct::component_arr_count
> changed to indicate how many errors to inject. In theory the
> driver could allocate and copy a correctly sized structure, but
> Zaid's code here is simpler, an this is hardly a critical path.
Right, allocate it once on driver init and keep massaging it on every
injection. Simple.
> This is just an improvement on my "option 1" (improved because all-ones
> for the component ID is going to be invalid for sure, while all zeroes
> could be a valid component).
Right, you need to know at injection time which of the components are valid
and which are not.
> Or just stop collecting on the first invalid one.
That would mean that you punish the user at the first typo. :-P
Considering how complex those interfaces become perhaps not such a good
idea...
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
