On Fri, May 30, 2025 at 01:52:39PM -0700, Luck, Tony wrote: > Use case to inject to one device would be: > > # echo 1 > nr_components What does that do? The interface probably needs a little refinement, but... > # echo 4 > component_id0 > # echo A5A5A5A5 > component_syndrome0 > ... set other files and finish with usual > # echo 1 > error_inject > > There isn't a fancy "debugfs_create_x128_le()" helper to manage these > 128-bit little endian numbers. So I've coded with the basic building > blocks (though using copy_from_user() and copy_to_user() feels like > back in the stone age). If there some helpers that I missed I'd be > happy to see that part simplified. > > Patch is on top of the existing v7 set. Obviously it needs to be folded > back into the earlier patches to make a clean history that doesn't add > functions and then replace them with different code. ... yes, definitely much better. Thanks! -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette