On 5/5/2025 10:27 AM, Rafael J. Wysocki wrote:
On Mon, May 5, 2025 at 5:15 PM Mario Limonciello <superm1@xxxxxxxxxx> wrote:
On 5/5/2025 10:03 AM, Rafael J. Wysocki wrote:
On Mon, May 5, 2025 at 4:58 PM Mario Limonciello <superm1@xxxxxxxxxx> wrote:
On 4/15/2025 4:27 PM, Mario Limonciello wrote:
From: Mario Limonciello <mario.limonciello@xxxxxxx>
CONFIG_ACPI_DEBUG can be helpful for getting debug messages on OEM
systems to identify a BIOS bug. It's a relatively small size increase
to turn it on by default (50kb) and that saves asking people to enable
it when an issue comes up because it wasn't in defconfig.
Enable it by default.
Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
Rafael,
Any thoughts on this? Especially in seeing Ingo trying to modernize
more of the defconfig [1]?
[1]
https://lore.kernel.org/lkml/20250505110946.1095363-1-mingo@xxxxxxxxxx/#t
I'm not sure if this is a good idea TBH.
The risk is that people will start reporting issues that have been
there already, but now they become visible due to enabling ACPI_DEBUG
by default.
As several distros already enable it by default I would have expected
some "noise" like this to have settled down.
Do you have specific messages in mind you think could be turning noisy
from the extra debug statements?
Nothing in particular, mostly messages coming from ACPICA, like the
ones complaining about missing objects that have always been missing
and the firmware is now too old for anyone to really care.
Those messages are only really useful when there is someone willing to
fix the issues that trigger them. Otherwise, they are just noise.
Ah I see. I suppose we could always have this on by default and if it
becomes untenable from reports flip it back to off.
Though if it is enabled by default by distros used by the vast
majority of people, it could be enabled by default in the mainline
too.
Do you know which distros enable it by default?
I know Ubuntu and CachyOS both do today. Fedora did it in some of their
kernels and they're pushing a change to enable it in more of them right now.