Re: [PATCH] ACPI: Enable CONFIG_ACPI_DEBUG by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/5/2025 10:03 AM, Rafael J. Wysocki wrote:
On Mon, May 5, 2025 at 4:58 PM Mario Limonciello <superm1@xxxxxxxxxx> wrote:

On 4/15/2025 4:27 PM, Mario Limonciello wrote:
From: Mario Limonciello <mario.limonciello@xxxxxxx>

CONFIG_ACPI_DEBUG can be helpful for getting debug messages on OEM
systems to identify a BIOS bug.  It's a relatively small size increase
to turn it on by default (50kb) and that saves asking people to enable
it when an issue comes up because it wasn't in defconfig.

Enable it by default.

Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>

Rafael,

Any thoughts on this?  Especially in seeing Ingo trying to modernize
more of the defconfig [1]?

[1]
https://lore.kernel.org/lkml/20250505110946.1095363-1-mingo@xxxxxxxxxx/#t

I'm not sure if this is a good idea TBH.

The risk is that people will start reporting issues that have been
there already, but now they become visible due to enabling ACPI_DEBUG
by default.

As several distros already enable it by default I would have expected some "noise" like this to have settled down.

Do you have specific messages in mind you think could be turning noisy from the extra debug statements?


---
   drivers/acpi/Kconfig | 1 +
   1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 7f10aa38269d2..cb190686499b9 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -394,6 +394,7 @@ config ACPI_TABLE_OVERRIDE_VIA_BUILTIN_INITRD

   config ACPI_DEBUG
       bool "Debug Statements"
+     default y
       help
         The ACPI subsystem can produce debug output.  Saying Y enables this
         output and increases the kernel size by around 50K.






[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux