On Fri, Apr 04, 2025 at 10:59:41AM +0800, Zijun Hu wrote: > On 2025/4/1 00:35, Andy Shevchenko wrote: > > Add a note to the fwnode.h that the header should not be used > > directly in the leaf drivers, they all should use the higher > > level APIs and the respective headers. ... > > + * Note, this header is not meant to be used by the leaf drivers. > > + * It provides the low level data types and definitions for the firmware > > Ack > > > + * and device property providers. The respective API headers should > > + * guarantee all the required data types and definitions without including > > + * this header directly into the driver. > > device property(include/linux/property.h) > ^ > | > firmware node(include/linux/fwnode.h) > ^ ^ ^ ^ > | | | | > DT ACPI SWNODE ... > > For various firmware implementations(DT|ACPI|SWNODE...), i feel we may > allow them include fwnode.h by their header or source files. That's the point, yes. And that's what exactly I put under the first sentence. The device property providers are not the leaf drivers in this sense. -- With Best Regards, Andy Shevchenko
