On 2025/4/1 00:35, Andy Shevchenko wrote: > Add a note to the fwnode.h that the header should not be used > directly in the leaf drivers, they all should use the higher > level APIs and the respective headers. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > > v2: added "...into the driver" piece at the end to remove ambiguity > > include/linux/fwnode.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h > index 6fa0a268d538..4c4d3f93534c 100644 > --- a/include/linux/fwnode.h > +++ b/include/linux/fwnode.h > @@ -2,6 +2,12 @@ > /* > * fwnode.h - Firmware device node object handle type definition. > * > + * Note, this header is not meant to be used by the leaf drivers. > + * It provides the low level data types and definitions for the firmware Ack > + * and device property providers. The respective API headers should > + * guarantee all the required data types and definitions without including > + * this header directly into the driver. device property(include/linux/property.h) ^ | firmware node(include/linux/fwnode.h) ^ ^ ^ ^ | | | | DT ACPI SWNODE ... For various firmware implementations(DT|ACPI|SWNODE...), i feel we may allow them include fwnode.h by their header or source files. > + * > * Copyright (C) 2015, Intel Corporation > * Author: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > */
