On Mon, 2025-08-25 at 15:20 +0000, Nikunj A Dadhania wrote: > + if (pml) { > + svm->pml_page = snp_safe_alloc_page(); > + if (!svm->pml_page) > + goto error_free_vmsa_page; > + } I didn't see this yesterday. Is it mandatory for AMD PML to use snp_safe_alloc_page() to allocate the PML buffer, or we can also use normal page allocation API? VMX PML just uses alloc_pages(). I was thinking the page allocation/free code could be moved to x86 common as shared code too.