On 8/28/2025 5:14 AM, Huang, Kai wrote:
> On Mon, 2025-08-25 at 15:20 +0000, Nikunj A Dadhania wrote:
>> + if (pml) {
>> + svm->pml_page = snp_safe_alloc_page();
>> + if (!svm->pml_page)
>> + goto error_free_vmsa_page;
>> + }
>
> I didn't see this yesterday. Is it mandatory for AMD PML to use
> snp_safe_alloc_page() to allocate the PML buffer, or we can also use
> normal page allocation API?
As it is dependent on HvInUseWrAllowed, I need to use snp_safe_alloc_page().
Tom?
> VMX PML just uses alloc_pages(). I was thinking the page allocation/free
> code could be moved to x86 common as shared code too.
Got that, because of the above requirement, I was going to share the variable
(pml_page) but do the allocation in the vmx/svm code.
Regards,
Nikunj
