Re: [PATCH v18 26/33] fs/resctrl: Introduce mbm_assign_on_mkdir to enable assignments on mkdir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Boris,

On 9/11/25 10:08, Borislav Petkov wrote:
> On Fri, Sep 05, 2025 at 04:34:25PM -0500, Babu Moger wrote:
>> The "mbm_event" counter assignment mode allows users to assign a hardware
>> counter to an RMID, event pair and monitor the bandwidth as long as it is
>> assigned.
>>
>> Introduce a user-configurable option that determines if a counter will
>> automatically be assigned to an RMID, event pair when its associated
>> monitor group is created via mkdir. Accessible when "mbm_event" counter
>> assignment mode is enabled.
> 
> This is just a note for the future - you don't have to go change things now:
> reading those commit messages back-to-back, there's a lot of boilerplate code
> which repeats with each commit message and there's a lot of text talking what
> the patch does.
> 
> Please tone this down in the future - it is really annoying and doesn't bring
> a whole lot by repeating things or explaining the obvious. Just concentrate on
> explaining why the patch exists and mention any non-obvious things.

Agreed. Thanks for the note.

-- 
Thanks
Babu Moger





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux