VFIO_CDX driver uses msi_domain_alloc_irqs() which is provided by non-user-visible GENERIC_MSI_IRQ, thus it should select that option directly. VFIO_CDX depends on CDX_BUS, which also will select GENERIC_MSI_IRQ (separate fix), nevertheless driver should poll what is being used there instead of relying on bus Kconfig. Without the fix on CDX_BUS compile test fails: drivers/vfio/cdx/intr.c: In function ‘vfio_cdx_msi_enable’: drivers/vfio/cdx/intr.c:41:15: error: implicit declaration of function ‘msi_domain_alloc_irqs’; did you mean ‘irq_domain_alloc_irqs’? [-Wimplicit-function-declaration] Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Closes: https://lore.kernel.org/r/4a6fd102-f8e0-42f3-b789-6e3340897032@xxxxxxxxxxxxx/ Fixes: 848e447e000c ("vfio/cdx: add interrupt support") Cc: <stable@xxxxxxxxxxxxxxx> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> --- drivers/vfio/cdx/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vfio/cdx/Kconfig b/drivers/vfio/cdx/Kconfig index e6de0a0caa32..90cf3dee5dba 100644 --- a/drivers/vfio/cdx/Kconfig +++ b/drivers/vfio/cdx/Kconfig @@ -9,6 +9,7 @@ config VFIO_CDX tristate "VFIO support for CDX bus devices" depends on CDX_BUS select EVENTFD + select GENERIC_MSI_IRQ help Driver to enable VFIO support for the devices on CDX bus. This is required to make use of CDX devices present in -- 2.48.1