Re: [PATCH v11 17/18] KVM: selftests: Don't use hardcoded page sizes in guest_memfd test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Fuad Tabba <tabba@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, kvmarm@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v11 17/18] KVM: selftests: Don't use hardcoded page sizes in guest_memfd test
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Fri, 6 Jun 2025 10:15:57 +0200
Cc: pbonzini@xxxxxxxxxx, chenhuacai@xxxxxxxxxx, mpe@xxxxxxxxxxxxxx, anup@xxxxxxxxxxxxxx, paul.walmsley@xxxxxxxxxx, palmer@xxxxxxxxxxx, aou@xxxxxxxxxxxxxxxxx, seanjc@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, brauner@xxxxxxxxxx, willy@xxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, xiaoyao.li@xxxxxxxxx, yilun.xu@xxxxxxxxx, chao.p.peng@xxxxxxxxxxxxxxx, jarkko@xxxxxxxxxx, amoorthy@xxxxxxxxxx, dmatlack@xxxxxxxxxx, isaku.yamahata@xxxxxxxxx, mic@xxxxxxxxxxx, vbabka@xxxxxxx, vannapurve@xxxxxxxxxx, ackerleytng@xxxxxxxxxx, mail@xxxxxxxxxxxxxxxxxxxxx, michael.roth@xxxxxxx, wei.w.wang@xxxxxxxxx, liam.merwick@xxxxxxxxxx, isaku.yamahata@xxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx, suzuki.poulose@xxxxxxx, steven.price@xxxxxxx, quic_eberman@xxxxxxxxxxx, quic_mnalajal@xxxxxxxxxxx, quic_tsoni@xxxxxxxxxxx, quic_svaddagi@xxxxxxxxxxx, quic_cvanscha@xxxxxxxxxxx, quic_pderrin@xxxxxxxxxxx, quic_pheragu@xxxxxxxxxxx, catalin.marinas@xxxxxxx, james.morse@xxxxxxx, yuzenghui@xxxxxxxxxx, oliver.upton@xxxxxxxxx, maz@xxxxxxxxxx, will@xxxxxxxxxx, qperret@xxxxxxxxxx, keirf@xxxxxxxxxx, roypat@xxxxxxxxxxxx, shuah@xxxxxxxxxx, hch@xxxxxxxxxxxxx, jgg@xxxxxxxxxx, rientjes@xxxxxxxxxx, jhubbard@xxxxxxxxxx, fvdl@xxxxxxxxxx, hughd@xxxxxxxxxx, jthoughton@xxxxxxxxxx, peterx@xxxxxxxxxx, pankaj.gupta@xxxxxxx, ira.weiny@xxxxxxxxx
In-reply-to: <20250605153800.557144-18-tabba@google.com>
Organization: Red Hat
References: <20250605153800.557144-1-tabba@google.com> <20250605153800.557144-18-tabba@google.com>
User-agent: Mozilla Thunderbird

On 05.06.25 17:37, Fuad Tabba wrote:

Using hardcoded page size values could cause the test to fail on systems
that have larger pages, e.g., arm64 with 64kB pages. Use getpagesize()
instead.

Also, build the guest_memfd selftest for arm64.

Suggested-by: Gavin Shan <gshan@xxxxxxxxxx>
Signed-off-by: Fuad Tabba <tabba@xxxxxxxxxx>
---


Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb

References:
- [PATCH v11 00/18] KVM: Mapping guest_memfd backed memory at the host for software protected VMs
  - From: Fuad Tabba
- [PATCH v11 17/18] KVM: selftests: Don't use hardcoded page sizes in guest_memfd test
  - From: Fuad Tabba

Prev by Date: Re: [PATCH v11 18/18] KVM: selftests: guest_memfd mmap() test when mapping is allowed
Next by Date: Re: [kvm-unit-tests PATCH v3 1/2] riscv: Add RV_INSN_LEN to processor.h
Previous by thread: [PATCH v11 17/18] KVM: selftests: Don't use hardcoded page sizes in guest_memfd test
Next by thread: Re: [PATCH v11 17/18] KVM: selftests: Don't use hardcoded page sizes in guest_memfd test
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]