On 6/3/2025 11:19 AM, Dave Hansen wrote: > On 6/3/25 11:02, Sohil Mehta wrote: >> The 3rd parameter pertains to handler "flags". The only flag in use >> right now is NMI_FLAG_FIRST. Assuming that more flags might get added >> later, the 0 should probably correspond to NMI_FLAG_NONE. Agree? >> >> The other option would be NMI_FLAG_LAST, which would be the opposite of >> NMI_FLAG_FIRST, but that seems shortsighted. > I don't feel as strongly about the flags. But this code has been there > for over a decade as-is, so I don't think we need to be planning to add > a bunch more flags. Sure, I'll leave the flags as-is for now to keep the focus of this series on NMI-source.