Thank you Robert. https://github.com/lamps-wg/dilithium-certificates/pull/145/files should fix that sentence. Please let us know if you have more feedback. -----Original Message----- From: Robert Sparks via Datatracker <noreply@xxxxxxxx> Sent: Friday, May 16, 2025 12:09 PM To: gen-art@xxxxxxxx Cc: draft-ietf-lamps-dilithium-certificates.all@xxxxxxxx; last-call@xxxxxxxx; spasm@xxxxxxxx Subject: [EXTERNAL] [lamps] draft-ietf-lamps-dilithium-certificates-09 ietf last call Genart review CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Document: draft-ietf-lamps-dilithium-certificates Title: Internet X.509 Public Key Infrastructure - Algorithm Identifiers for the Module-Lattice-Based Digital Signature Algorithm (ML-DSA) Reviewer: Robert Sparks Review result: Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-lamps-dilithium-certificates-09 Reviewer: Robert Sparks Review Date: 2025-05-16 IETF LC End Date: 2025-05-21 IESG Telechat date: Not scheduled for a telechat Summary: Ready for publication as a Proposed Standard RFC Minor comments: Reproducing OneAsymmetricKey from 5958 in section 6 brings some maintenance cost should that ever need to be touched. I twitched at the way RECOMMENDED was used in the first sentence of section 8, but got over it. The first sentence of the second paragraph of section 10 is hard to read. Maybe it's the "scheme are" disagreement, or maybe it's the repeated use of "under" - could it be restructured into simpler sentences? Caveat: I didn't verify any of the examples. _______________________________________________ Spasm mailing list -- spasm@xxxxxxxx To unsubscribe send an email to spasm-leave@xxxxxxxx -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
