On Thu, Aug 28, 2025 at 03:46:35PM -0700, Junio C Hamano wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > Changes in v2: > > - Fix a comment typo. > > - Introduce another commit that simplifies the calling convention for > > `link_alt_odb_entry()`. > > - Link to v1: https://lore.kernel.org/r/20250729-b4-pks-midx-deduplicate-source-info-v1-0-748db2eda3b5@xxxxxx > > > > Changes in v3: > > - Introduce `odb_find_source_or_die()` so that we don't have to repeat > > the calls to `die()`, as suggested by Taylor. > > - Split out a patch to adapt `link_alt_odb_entry()` and friends to > > consistently name the parameter that refers to the alternate object > > directory's path. > > - Link to v2: https://lore.kernel.org/r/20250807-b4-pks-midx-deduplicate-source-info-v2-0-bcffb8fc119c@xxxxxx > > This has gone quiet even though the previous two iterations got > fairly detailed review. Should we declare victory and mark the > topic for 'next' now? No objections from me; though I still would feel a little better with Stolee's opinion on the MIDX --object-dir stuff. Thanks, Taylor
