On 8/28/25 8:34 PM, Taylor Blau wrote:
On Thu, Aug 28, 2025 at 03:46:35PM -0700, Junio C Hamano wrote:
Patrick Steinhardt <ps@xxxxxx> writes:
Changes in v2:
- Fix a comment typo.
- Introduce another commit that simplifies the calling convention for
`link_alt_odb_entry()`.
- Link to v1: https://lore.kernel.org/r/20250729-b4-pks-midx-deduplicate-source-info-v1-0-748db2eda3b5@xxxxxx
Changes in v3:
- Introduce `odb_find_source_or_die()` so that we don't have to repeat
the calls to `die()`, as suggested by Taylor.
- Split out a patch to adapt `link_alt_odb_entry()` and friends to
consistently name the parameter that refers to the alternate object
directory's path.
- Link to v2: https://lore.kernel.org/r/20250807-b4-pks-midx-deduplicate-source-info-v2-0-bcffb8fc119c@xxxxxx
This has gone quiet even though the previous two iterations got
fairly detailed review. Should we declare victory and mark the
topic for 'next' now?
No objections from me; though I still would feel a little better with
Stolee's opinion on the MIDX --object-dir stuff.
Sorry I had missed this series and in particular how it handles the
--object-dir option.
I think the modification to add structure to the --object-dir option
by passing around an object source is going to make things better.
The one thing I was very careful about was that we are not trying
to create a full "repository" struct based on the object-dir, because
there may not be one! We only know that there is an alternate object
database where we want to break the norm and perform writes. The
changes here make that seem like it continues to work.
Thanks,
-Stolee
