Hi, this patch series addresses an issue with storing duplicate object IDs sent by the client in git-upload-pack(1). If the client sends repeated "have" lines for an object ID that doesn't refer to a commit, then we end up storing that object ID repeatedly in the `have_obj` array. This leads to sending out repeated "ACK"s for the same object. The series applies on top of "maint" at c44beea485 (Git 2.51, 2025-08-17). Thanks! Patrick --- Patrick Steinhardt (2): t5530: modernize tests upload-pack: don't ACK non-commits repeatedly in protocol v2 t/t5530-upload-pack-error.sh | 68 +++++++++++++++++++++++++++----------------- upload-pack.c | 19 ++++++------- 2 files changed, 51 insertions(+), 36 deletions(-) --- base-commit: c44beea485f0f2feaf460e2ac87fdd5608d63cf0 change-id: 20250903-b4-pks-upload-pack-repeated-non-commit-acks-49b363e1d0e1