Patrick Steinhardt <ps@xxxxxx> writes: >> builtin/pack-refs.c | 31 ++++++++++++++++++++----------- >> pack-refs.h | 22 ++++++++++++++++++++++ >> 2 files changed, 42 insertions(+), 11 deletions(-) >> create mode 100644 pack-refs.h > > Shouldn't that header live in "builtin/pack-refs.h"? Makes it way more > obvious that it exposes functions from "builtin/pack-refs.c". There shouldn't be any *.h files in builtin/. since the top-level is where the library-ish reusable things live, so that they can eventually be used by more than one *.c files in builtin/ and also by other *.c files outside builtin.
