On Wed, Sep 03, 2025 at 10:54:06AM +0100, Phillip Wood wrote: > On 03/09/2025 05:44, Patrick Steinhardt wrote: > > Tests should be agnostic of that name and use e.g. git-symbolic-ref(1) > > to figure out what HEAD points to. So maybe we should follow through > > with that idea and start refactoring tests into this direction so that > > they never set or read the variable in the first place. > > That might be a good direction for the future. The test suite could set > TEST_DEFAULT_BRANCH to the default name and tests could use that rather > setting GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME and hard coding the expected > name or running 'git symbolic-ref'. > > I'll drop the removal of GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME but I'd like > to keep the patches that switch the tests from using "master" to "main". > We've converted nearly all of the tests already so it seems a shame to leave > a handful unconverted. Fair enough. Patrick
