ノウラ | Flare <nouraellm@xxxxxxxxx> writes:
> The point of the check was to avoid subtle crashes
> aligning with defensive programming requirements.
It is a programming error, period. Do not silently return. That's
not being defensive. That is sweeping a problem under the rug.
We can always do assert() or if (condition) BUG("...") if we are
unsure about the ability of our developers to grok subtle
pre-conditions to call into certain code paths, and I would call
that defensive.
But I do not see a need for _this_ particular call. Our developers
should be able to see what they are supposed to call it with just
fine.
Thanks.
