Re: A Question from a Hopeful Future Contributor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 28, 2025 at 11:02 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> "D. Ben Knoble" <ben.knoble@xxxxxxxxx> writes:
>
> >> >> * "git status" on intent-to-add index entries (say "I" in the first
> >> >>   column instead of "A" for short status, add "(needs 'git add')" at the
> >> >>   end of "new file: $path " in long status).
> >> >
> >> > I am interpreting this todo message as meaning that the following behavior
> >> > should be implemented:
> >>
> >> I think that was done long time ago.  The entry may have been a wish-item
> >> in April 2011, but not anymore.
> >
> > At least in 2.48.1 and in git version 2.50.0.rc0.48.g74dbe4346c, this
> > behavior isn't present. So I wouldn't call it "done"—maybe there was a
> > discussion that it shouldn't be done, though? I didn't search the
> > list.
>
> I didn't either, so this response may not be adding much value, but
> I think the intent of the above entry is so that the output allows
> users to tell between already added entries and about to be added
> entries.  Perhaps in an ancient version of "git status" did not give
> enough information to allow us to tell the status of the index entry
> for the path and the status of the working tree file for the path
> separately, or something?
>
> In any case, we do not need to add anything to achieve that today.

[snip examples

All fair points, and matches with what I see—I was expecting to find
something more explicit about intent in the output based on the todo
item ("_I" vs "_A"; "(needs 'git add')" or better verbiage), but
you're right that the existing output does indicate the state (if
indirectly).

-- 
D. Ben Knoble





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux