Re: [PATCH] rev-list: update a NEEDSWORK comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Junio C Hamano <gitster@xxxxxxxxx>
Subject: Re: [PATCH] rev-list: update a NEEDSWORK comment
From: Jeff King <peff@xxxxxxxx>
Date: Tue, 22 Jul 2025 04:16:59 -0400
Cc: git@xxxxxxxxxxxxxxx
In-reply-to: <xmqqecu9w4a5.fsf@gitster.g>
References: <xmqqa551127o.fsf@gitster.g> <xmqqecu9w4a5.fsf@gitster.g>

On Mon, Jul 21, 2025 at 03:46:42PM -0700, Junio C Hamano wrote:

> The comment was poorly phrased and it wasn't clear what it wanted to
> say.  Strongly discourage this broken pattern to be copied and
> pasted to other code paths.

Thanks, I was much less confused after your re-wording.

-Peff

References:
- [PATCH] rev-list: make "struct rev_list_info" static to the only user
  - From: Junio C Hamano
- [PATCH] rev-list: update a NEEDSWORK comment
  - From: Junio C Hamano

Prev by Date: [PATCH v2 4/4] t/helper/test-delta: close fd if fstat() fails after second open()
Next by Date: Re: [PATCH v2 2/4] builtin/archive: close file descriptor on dup2() failure
Previous by thread: [PATCH] rev-list: update a NEEDSWORK comment
Next by thread: Re: [PATCH] rev-list: update a NEEDSWORK comment
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux