The structure has nothing to do with what "git bisect" does; as nobody other than "git rev-list" implementation uses it, move it as a private data type to builtin/rev-list.c Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> --- * https://lore.kernel.org/git/xmqq1qdptffk.fsf@gitster.g/ had this #leftoverbits tangent. bisect.h | 8 -------- builtin/rev-list.c | 10 +++++++++- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/bisect.h b/bisect.h index 944439bfac..8621460f93 100644 --- a/bisect.h +++ b/bisect.h @@ -27,14 +27,6 @@ struct commit_list *filter_skipped(struct commit_list *list, #define FIND_BISECTION_ALL (1u<<0) #define FIND_BISECTION_FIRST_PARENT_ONLY (1u<<1) -struct rev_list_info { - struct rev_info *revs; - int flags; - int show_timestamp; - int hdr_termination; - const char *header_prefix; -}; - /* * enum bisect_error represents the following return codes: * BISECT_OK: success code. Internally, it means that next diff --git a/builtin/rev-list.c b/builtin/rev-list.c index 0984b607bf..0a89f4cbf7 100644 --- a/builtin/rev-list.c +++ b/builtin/rev-list.c @@ -28,6 +28,14 @@ #include "quote.h" #include "strbuf.h" +struct rev_list_info { + struct rev_info *revs; + int flags; + int show_timestamp; + int hdr_termination; + const char *header_prefix; +}; + static const char rev_list_usage[] = "git rev-list [<options>] <commit>... [--] [<path>...]\n" "\n" @@ -652,7 +660,7 @@ int cmd_rev_list(int argc, */ /* * NEEDSWORK: These loops that attempt to find presence of - * options without understanding that the options they are + * options without understanding the options they are * skipping are broken (e.g., it would not know "--grep * --exclude-promisor-objects" is not triggering * "--exclude-promisor-objects" option). We really need -- 2.50.1-446-g8227aac02a
