On 22 July 2025 5:49:42 am IST, "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: >On 2025-07-21 at 19:13:56, Junio C Hamano wrote: >> Aditya Garg <gargaditya08@xxxxxxxx> writes: >> >> > +sendemail.imapfolder:: >> >> Do we expect that the use of IMAP in git-send-email will be limited >> forever to store outgoing e-mails to the Sent folder? I highly >> doubt it. For example, would it be plausible that given send-email >> has so much richer feature set compared to imap-send, it would not >> be implausible for users of imap-send that want to stuff messages, >> with Cc's, threading, etc., all prepared by send-email, to their >> outgoing folder. >> >> And when somebody wants to add such a feature to "git send-email", >> how would they find this variable that uses imap-send for quite a >> different purpose squatting on its name? >> >> Same comment for the --imap-folder command line option and the >> internal variable(s) used to implement this feature. >> >> These things should be named with words like "sent", "fcc", etc., to >> clarify the use case this new feature is trying to support. > >I think this is a good idea. We should be thoughtful about our option >names here. > As I said to Junio, I am happy to have ideas on better names, since I would like to clarify that sent folder is a typical use case, but the variable can be used for any IMAP folder. >> As imap-send is not part of my daily workflow, I have no strong >> opinions for or against the proposed feature, and I didn't find >> anything glaringly wrong in the implementation, other than the poor >> naming that would block possible future enhancements. > >I would also like to advocate in favour of the feature in general. I >run my own mail server and there is no magical functionality to add my >outgoing emails to the Sent folder, so I can definitely see the utility >of this functionality. I'm sure there are also other, larger mail >providers for which this would be useful as well. (I suspect the patch >author is on one of them, in fact.) Fortunately my Outlook email which I am using for this chat has the magic functionality of saving a copy to sent folder, but my personal iCloud email does not, which after this patch works as intended.
