On 22 July 2025 12:43:56 am IST, Junio C Hamano <gitster@xxxxxxxxx> wrote: >Aditya Garg <gargaditya08@xxxxxxxx> writes: > >> +sendemail.imapfolder:: > >Do we expect that the use of IMAP in git-send-email will be limited >forever to store outgoing e-mails to the Sent folder? I highly >doubt it. For example, would it be plausible that given send-email >has so much richer feature set compared to imap-send, it would not >be implausible for users of imap-send that want to stuff messages, >with Cc's, threading, etc., all prepared by send-email, to their >outgoing folder. I have left that feature opened, thus I have not hardcoded and folder name here. You can simply set imapfolder as Outgoing, Drafts etc as well. Or maybe you mean, ONLY send via imap and don't use SMTP? Like this users can use their email clients to send emails? > >And when somebody wants to add such a feature to "git send-email", >how would they find this variable that uses imap-send for quite a >different purpose squatting on its name? > >Same comment for the --imap-folder command line option and the >internal variable(s) used to implement this feature. > >These things should be named with words like "sent", "fcc", etc., to >clarify the use case this new feature is trying to support. > IMAP folder is a simple variable that decides to which folder the mails need to be sent. It can be sent, outbox, Drafts etc. I don't think any future enhancement would have any confusion with this? For cases which want to use ONLY IMAP send, a bool like use_imap_only etc can be used with imap_folder. Although, I am open to better name suggestions. >As imap-send is not part of my daily workflow, I have no strong >opinions for or against the proposed feature, and I didn't find >anything glaringly wrong in the implementation, other than the poor >naming that would block possible future enhancements. > >Thanks. >
