Re: [GSOC PATCH v5 0/2] commit: improve behaviour of core.commentChar=auto for comments in commit messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Phillip Wood <phillip.wood123@xxxxxxxxx>
Subject: Re: [GSOC PATCH v5 0/2] commit: improve behaviour of core.commentChar=auto for comments in commit messages
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Wed, 16 Jul 2025 08:29:55 -0700
Cc: Ayush Chandekar <ayu.chandekar@xxxxxxxxx>, christian.couder@xxxxxxxxx, git@xxxxxxxxxxxxxxx, shyamthakkar001@xxxxxxxxx, kristofferhaugsbakk@xxxxxxxxxxxx
Feedback-id: if26b431b:Fastmail
In-reply-to: <51e75a0f-fc6c-452c-b1c3-2836d1508308@gmail.com> (Phillip Wood's message of "Wed, 16 Jul 2025 15:28:00 +0100")
References: <20250626132233.414789-1-ayu.chandekar@gmail.com> <cover.1752665506.git.ayu.chandekar@gmail.com> <51e75a0f-fc6c-452c-b1c3-2836d1508308@gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13)

Phillip Wood <phillip.wood123@xxxxxxxxx> writes:

> This version looks good to me, thanks for working on it.
>
> Junio - shall I rebase 'pw/3.0-commentchar-auto-deprecation' on top of
> this when I re-roll to avoid conflicts?

Sounds sensible.  I can drop my merge-fix then.

Thanks.

References:
- [GSOC PATCH] commit: avoid scanning trailing comments when 'core.commentChar' is "auto"
  - From: Ayush Chandekar
- [GSOC PATCH v5 0/2] commit: improve behaviour of core.commentChar=auto for comments in commit messages
  - From: Ayush Chandekar
- Re: [GSOC PATCH v5 0/2] commit: improve behaviour of core.commentChar=auto for comments in commit messages
  - From: Phillip Wood

Prev by Date: Re: [GSOC PATCH 2/2] config: set comment_line_str to "#" when core.commentChar=auto
Next by Date: Re: [PATCH v3 3/4] refs: selectively set prefix in the seek functions
Previous by thread: Re: [GSOC PATCH v5 0/2] commit: improve behaviour of core.commentChar=auto for comments in commit messages
Next by thread: [PATCH] daemon: correctly handle soft accept() errors
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]