Hi Ayush
On 16/07/2025 12:43, Ayush Chandekar wrote:
Hey everyone,
The aim of this patch series is to improve the behaviour of core.commentChar=auto by the following patches:
1/2 - Fix a bug which reads comment character of the comments in commit message leading to change in the value of `comment_line_str` and thus resulting the comments in the final commit message.
2/2 - Standardizes the behaviour of code by resetting the 'comment_line_str' to "#" when 'core.commentChar' is set to "auto".
This version looks good to me, thanks for working on it.
Junio - shall I rebase 'pw/3.0-commentchar-auto-deprecation' on top of
this when I re-roll to avoid conflicts?
Thanks
Phillip
Thanks to Junio, Phillip and Kristoffer for reviewing the patches and also Christian for the reviews and mentoring me.
The only difference between this version (v5) and the previous one is that I've added credit to Phillip for patch (2/2).
Ayush Chandekar (2):
commit: avoid scanning trailing comments when 'core.commentChar' is
"auto"
config: set comment_line_str to "#" when core.commentChar=auto
builtin/commit.c | 6 +++++-
config.c | 6 ++++--
t/t3418-rebase-continue.sh | 13 +++++++++++++
3 files changed, 22 insertions(+), 3 deletions(-)
J
