Re: [PATCH v2 4/4] for-each-ref: introduce a '--skip-until' option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Karthik Nayak <karthik.188@xxxxxxxxx> writes:
>
>> +	if (filter.seek && sorting_options.nr > 1)
>> +		die(_("cannot use --skip-until custom sort options"));
>
> Missing "with" before "custom sort".
>

Thanks, will fix in the next version.

> When I commented on the previous iteration about sorting, I didn't
> mean to suggest making them incompatible---it may have some use case
> to grab a batch out of the underlying refstore, sort refs in that
> batch, and then show them.  But from usability's point of view, I
> tend to agree with this design decision.  Such an unnatural batching
> and sorting operation is probably not worth supporting.

I think so too, there might be some usecase, when that usecase is more
concrete we can probably re-visit this.

For now, it is confusing and it is just easier to not support them
together.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux