Re: [PATCH v2] ssh signing: don't detach the filename strbuf from key_file tempfile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/07/2025 17:22, redoste wrote:
On Mon Jul 7, 2025 at 17:26 CEST, Phillip Wood wrote:
test_file_is_empty will print a diagnostic message if it fails so it
should be clear what has caused the test failure
Uh, okay, this makes sense and I think it will be clear enough.
However there is only `test_file_not_empty`, `test_file_is_empty`
doesn't exist. I will implement it in an other commit.

Sorry I'd misremembered the name, it is "test_must_be_empty"

Phillip
The way I see it is that the changes that are being tested are related
to commit signing as the invariant that we want to assert is that
temporary files are cleaned up after signing commits.
I see.

I will update this for a v3.
Thanks for the feedback!






[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux