On Sun, Jul 06, 2025 at 07:34:49PM +0200, redoste wrote:
> diff --git a/t/t7528-signed-commit-ssh.sh b/t/t7528-signed-commit-ssh.sh
> index 065f780636..1a8d96f355 100755
> --- a/t/t7528-signed-commit-ssh.sh
> +++ b/t/t7528-signed-commit-ssh.sh
> @@ -390,6 +390,22 @@ test_expect_success GPGSSH 'check config gpg.format values' '
> test_must_fail git commit -S --amend -m "fail"
> '
>
> +test_expect_success GPGSSH 'check temporary files clean up when signing commits' '
> + test_config gpg.format ssh &&
> + eval $(ssh-agent) &&
> + test_when_finished "kill ${SSH_AGENT_PID}" &&
> + mkdir tmpdir &&
> + TMPDIR="$(pwd)/tmpdir" &&
> + export TMPDIR &&
I think this exported environment variable now leaks into subsequent
tests, doesn't it? We may want to do it in a subshell.
mkdir tmpdir &&
TMPDIR="$(pwd)/tmpdir" &&
(
export TMPDIR &&
ssh-add "${GPGSSH_KEY_PRIMARY}" &&
echo 1 >file && git add file &&
git commit -a -m inline -S"$(cat "${GPGSSH_KEY_PRIMARY}.pub")" &&
echo 2 >file &&
git commit -a -m file -S"${GPGSSH_KEY_PRIMARY}"
) &&
find tmpdir -type f >tmpfiles &&
test_line_count = 0 tmpfiles
Patrick
> + ssh-add "${GPGSSH_KEY_PRIMARY}" &&
> + echo 1 >file && git add file &&
> + git commit -a -m inline -S"$(cat "${GPGSSH_KEY_PRIMARY}.pub")" &&
> + echo 2 >file &&
> + git commit -a -m file -S"${GPGSSH_KEY_PRIMARY}" &&
> + find tmpdir -type f >tmpfiles &&
> + test_line_count = 0 tmpfiles
> +'
> +
> test_expect_failure GPGSSH 'detect fudged commit with double signature (TODO)' '
> sed -e "/gpgsig/,/END PGP/d" forged1 >double-base &&
> sed -n -e "/gpgsig/,/END PGP/p" forged1 | \
> --
> 2.49.0
>
>
