On Thu, Jun 19, 2025 at 08:35:35AM -0800, Junio C Hamano wrote: > > diff --git c/Makefile w/Makefile > index 70d1543b6b..2c17868a24 100644 > --- c/Makefile > +++ w/Makefile > @@ -3475,8 +3475,10 @@ coccicheck-test: $(COCCI_TEST_RES_GEN) > coccicheck: coccicheck-test > ifdef SPATCH_CONCAT_COCCI > coccicheck: contrib/coccinelle/ALL.cocci.patch > + ! test -s contrib/coccinelle/ALL.cocci.patch > else > coccicheck: $(COCCICHECK_PATCHES_INTREE) > + test $$(cat $(COCCICHECK_PATCHES_INTREE) | wc -c) = 0 Definitely a nitpick, but I think using `-eq` instead of `=` and might even come handy from a portability point of view. Just like Peff, agree would be a big improvement to have this changed for usability. Carlo
