On Thu, Jun 19, 2025 at 08:35:35AM -0700, Junio C Hamano wrote: > With "make coccicheck", we generate contrib/coccinelle/*.cocci.patch > files that contain changes suggested by semantic patches, but "make" > succeeds. Admittedly, not many developers may run "make coccicheck" > in the first place, but it makes it harder to notice when they do > run it after they introduced an iffy piece of code. I admit that I do not run coccicheck very often. But I have definitely been surprised by it not triggering a make failure when there are changes to be made. So I'd be in favor of this patch. -Peff
