On 2025-06-11 11:31 p.m., Collin Funk wrote:
Hi Brad,
Brad Smith <brad@xxxxxxxxxxxx> writes:
FreeBSD 6.0 has memmem().
Signed-off-by: Brad Smith <brad@xxxxxxxxxxxx>
---
config.mak.uname | 6 ------
1 file changed, 6 deletions(-)
diff --git a/config.mak.uname b/config.mak.uname
index b1c5c4d5e8..da592eeaa0 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -302,16 +302,10 @@ ifeq ($(uname_S),FreeBSD)
ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)
OLD_ICONV = YesPlease
endif
- NO_MEMMEM = YesPlease
I don't have a FreeBSD machine that old to test it. But Gnulib's
documentation says it was added in FreeBSD 5.2.1 [1].
Not that it matters for git, but that does not match the actual code.
The first man page I see is for 6 and looking at their source repo I
only see memmem() on the 6 branch.
https://svnweb.freebsd.org/base/stable/5/lib/libc/string/
https://svnweb.freebsd.org/base/stable/6/lib/libc/string/
Reviewed-by: Collin Funk <collin.funk1@xxxxxxxxx>
BASIC_CFLAGS += -I/usr/local/include
BASIC_LDFLAGS += -L/usr/local/lib
DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
USE_ST_TIMESPEC = YesPlease
- ifeq ($(shell expr "$(uname_R)" : '4\.'),2)
- PTHREAD_LIBS = -pthread
- NO_UINTMAX_T = YesPlease
- NO_STRTOUMAX = YesPlease
- endif
PYTHON_PATH = /usr/local/bin/python
PERL_PATH = /usr/local/bin/perl
HAVE_PATHS_H = YesPlease
Curious about this change though. Are you basing it off a FreeBSD system
you have? Or do we not care about that old version anymore? For
reference, FreeBSD 4.2 was released in 2000.
I probably should have mentioned it in some manner in the commit message.
Since the minimum version is now 6.x after this changed I removed the 4.x
support. 6.0 is 19.5 years old.
Collin
[1] https://www.gnu.org/software/gnulib/manual/html_node/memmem.html
[2] https://www.freebsd.org/releases/4.2R/announce/
