Hi Brad, Brad Smith <brad@xxxxxxxxxxxx> writes: > Building on Solaris I noticed the following two issues with Solaris sed. > > GEN version-def.h > sed: Missing newline at end of file standard input. > > GEN config-list.h > sed: illegal option -- E > Usage: sed [-n] script [file...] > sed [-n] [-e script]...[-f script_file]...[file...] > > > https://github.com/git/git/commit/e1b81f54da80267edee2cb8fd0d0f75f03023019 > > The second issue being introduced fairly recently. Not sure what would be > appropriate fixes. Just pointing them out if someone has an suggestions for > fixes. I noticed these as well, but just ignored them since it seems to build fine. The first one seems like just a warning? Probably something to do with POSIX defining a "Text File" as "A file that contains characters organized into zero or more lines" where a line is "A sequence of zero or more non- <newline> characters plus a terminating <newline> character." The second is more tricky. The '-E' option to use EREs was not added to the specification for 'sed' until POSIX.1-2024 [1]. Maybe the script could check for the 'gsed' command? All of the (few) Solaris machines I use will have many GNU programs installed like that. Collin [1] https://pubs.opengroup.org/onlinepubs/9799919799/utilities/sed.html
