On Wed, May 21, 2025 at 5:00 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Christian Couder <christian.couder@xxxxxxxxx> writes: > > > I don't think it would bring a lot of benefits. Using an strmap or a > > sorted string list might make things faster if there are a lot of > > promisor remotes configured on the clients, but I don't think we are > > at a point where such an optimisation is worth it. > > What I was getting at using common collection types instead of > rolling your own linked list was not primarily about performance. > They are more battle-tested and much easier to readers who are > familiar with these existing types. OK, I have implemented the string_list approach you suggested that uses the nickname as the key (item->string) with a pointer to a promisor_info structure as the data (item->util) in the v4. The string_list is sorted when it can be useful. Also remote_nick_find() has been renamed promisor_info_find().
