On Tue, May 20, 2025 at 11:37 AM Karthik Nayak <karthik.188@xxxxxxxxx> wrote: > > Christian Couder <christian.couder@xxxxxxxxx> writes: > > [snip] > > > > > /* > > - * Find first index of 'nicks' where there is 'nick'. 'nick' is > > - * compared case sensitively to the strings in 'nicks'. If not found > > - * 'nicks->nr' is returned. > > + * Find first element of 'p' where the 'name' member is 'nick'. 'nick' > > + * is compared case sensitively to the strings in 'p'. If not found > > + * NULL is returned. > > */ > > -static size_t remote_nick_find(struct strvec *nicks, const char *nick) > > +static struct promisor_info *remote_nick_find(struct promisor_info *p, const char *nick) > > Nit: while we're here wouldn't be nicer to rename this to > `promiser_info_list_find_name` or similar? Junio suggested this name in a discussion of a previous patch series: https://lore.kernel.org/git/xmqqa5bbq0nb.fsf@gitster.g/ I am not sure that changing its first argument from a `struct strvec *` to a `struct promisor_info *` makes it worth renaming. If that's the case, then I would be fine with renaming it like you suggest though.
