On Monday, 2 June 2025 20:41:48 CEST Collin Funk wrote: > The OpenBSD 'sed' command does not support '\n' to represent newlines in > sed expressions. This leads to the follow compiler error: > > In file included from builtin/help.c:15: > ./config-list.h:282:18: error: use of undeclared identifier 'n' > "gitcvs.dbUser",n "gitcvs.dbPass", > ^ > 1 error generated. > gmake: *** [Makefile:2821: builtin/help.o] Error 1 > > We can use a variable that expands to a newline to do this portably. > > This portably issue was introduced in e1b81f54da (completion: take into > account the formatting backticks for options, 2025-03-19) > > Signed-off-by: Collin Funk <collin.funk1@xxxxxxxxx> > --- > generate-configlist.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/generate-configlist.sh b/generate-configlist.sh > index b06da53c89..48ec8d9812 100755 > --- a/generate-configlist.sh > +++ b/generate-configlist.sh > @@ -1,5 +1,8 @@ > #!/bin/sh > > +nl=' > +' > + > SOURCE_DIR="$1" > OUTPUT="$2" > > @@ -19,7 +22,7 @@ EOF > s/::$//; > s/`//g; > s/^.*$/ "&",/; > - s/, */",\n "/g; > + s/, */",''"$nl"'' "/g; > p;}; > d' \ > "$SOURCE_DIR"/Documentation/*config.adoc \ Hello, I was on this issue here: https://github.com/git/git/commit/e1b81f54da80267edee2cb8fd0d0f75f03023019 Your proposed fix is interesting in that it does not spawn an additional process, but it does not work for me (debian sh = dash). ᐅ diff config-list.h config-list.h.new 281d280 < "gitcvs.dbPass", 283c282 < "gitcvs.dbUser", --- > "gitcvs.dbUser","$nl" "gitcvs.dbPass", 350,351c349 < "http.lowSpeedLimit", < "http.lowSpeedTime", --- > "http.lowSpeedLimit","$nl" "http.lowSpeedTime", If you'd like to test your patch on different systems and happen to have a github account, you can open a PR to gitgitgadget/git . This will trigger builds on several targets. Thanks, JN
