Re: [PATCH v3 06/10] t/test-lib: fix TAP format for BASH_XTRACEFD warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick Steinhardt <ps@xxxxxx> writes:

> When the Bash version is too old to support BASH_XTRACEFD we print a
> warning to stderr. This warning breaks the TAP format because it is not
> prefixed with a "#". Fix this.
>

Nit: The important bit here is that TAP treats anything that starts with a
'#' as a comment. Everything else is parsed. Since this is warning which
shouldn't be parsed, we add the '#'. Perhaps worthwhile adding this
extra context to the commit. Anyways not worth a re-roll.

[snip]

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux