Patrick Steinhardt <ps@xxxxxx> writes: > We have several flags like "--verbose", "--verbose-only" or "-x" that > cause us to generate shell traces. The generated tracing output is split > up in these cases so that the test's stdout is printed to file > descriptor 3 whereas its stderr is printed to file descriptor 4. > Depending on which options have been given, we then end up either: > > - Redirecting both file descriptors to a file. > > - Redirecting them to stdout and stderr, respectively. > > - Closing them in case we're running in none-verbose mode. > > The second case causes problems though when passing output to a TAP > parser. We print the test's stdout to the console's stdout, and that > results in broken TAP output. > > Fix the issue by instead redirecting the test's stdout to the shell's > stderr. This makes it impossible to discern stdout from stderr, but > going by my own experience I never came across a usecase where I would > have needed this distinction. > Fair enough. I wonder how we can retain this distinction, perhaps write stdout to user provided file. Or add some prefix to distinguish the two when output to stderr. Nevertheless, this should be fine. The changes itself look good to me. [snip]
Attachment:
signature.asc
Description: PGP signature
