Re: [PATCH v2] cvsserver: avoid precedence problem between ! and %s

[Junio C Hamano <gitster@xxxxxxxxx>]

"Ondřej Pohořelský via GitGitGadget" <gitgitgadget@xxxxxxxxx>
writes:

> From: =?UTF-8?q?Ond=C5=99ej=20Poho=C5=99elsk=C3=BD?= <opohorel@xxxxxxxxxx>
>
> With perl-5.41.4 and newer, git-cvsserver fails to build because of
> possible precedence problem[0]
>
> Added parentheses avoid this issue.
>
> [0] https://metacpan.org/release/ETHER/perl-5.41.12/view/pod/perl5414delta.pod#New-Warnings
>
> Reported-by: Jitka Plesnikova <jplesnik@xxxxxxxxxx>
> Suggested-by: Jitka Plesnikova <jplesnik@xxxxxxxxxx>
> Signed-off-by: Ondřej Pohořelský <opohorel@xxxxxxxxxx>
> ---
>  git-cvsserver.perl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-cvsserver.perl b/git-cvsserver.perl
> index a4e1bad33ca..076c10cb2c2 100755
> --- a/git-cvsserver.perl
> +++ b/git-cvsserver.perl
> @@ -5009,7 +5009,7 @@ sub escapeRefName
>      #   = "_-xx-" Where "xx" is the hexadecimal representation of the
>      #     desired ASCII character byte. (for anything else)
>  
> -    if(! $refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/)
> +    if(! ($refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/))
>      {
>          $refName=~s/_-/_-u--/g;
>          $refName=~s/\./_-p-/g;

Thanks, will queue.