From: =?UTF-8?q?Ond=C5=99ej=20Poho=C5=99elsk=C3=BD?= <opohorel@xxxxxxxxxx> With perl-5.41.4 and newer, git-cvsserver fails to build because of possible precedence problem[0] Added parentheses avoid this issue. [0] https://metacpan.org/release/ETHER/perl-5.41.12/view/pod/perl5414delta.pod#New-Warnings Reported-by: Jitka Plesnikova <jplesnik@xxxxxxxxxx> Suggested-by: Jitka Plesnikova <jplesnik@xxxxxxxxxx> Signed-off-by: Ondřej Pohořelský <opohorel@xxxxxxxxxx> --- cvsserver: avoid precedence problem between ! and %s cc: "Kristoffer Haugsbakk" kristofferhaugsbakk@xxxxxxxxxxxx Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1925%2Fopohorel%2Fcvsserver_parentheses-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1925/opohorel/cvsserver_parentheses-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/1925 Range-diff vs v1: 1: 42c03c4b044 ! 1: a15f924657c cvsserver: avoid precedence problem between ! and %s @@ Commit message Added parentheses avoid this issue. - Full credit for finding the issue and coming up with the fix goes to - Jitka Plesnikova (jplesnik@xxxxxxxxxx) - [0] https://metacpan.org/release/ETHER/perl-5.41.12/view/pod/perl5414delta.pod#New-Warnings + Reported-by: Jitka Plesnikova <jplesnik@xxxxxxxxxx> + Suggested-by: Jitka Plesnikova <jplesnik@xxxxxxxxxx> Signed-off-by: Ondřej Pohořelský <opohorel@xxxxxxxxxx> ## git-cvsserver.perl ## git-cvsserver.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index a4e1bad33ca..076c10cb2c2 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -5009,7 +5009,7 @@ sub escapeRefName # = "_-xx-" Where "xx" is the hexadecimal representation of the # desired ASCII character byte. (for anything else) - if(! $refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/) + if(! ($refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/)) { $refName=~s/_-/_-u--/g; $refName=~s/\./_-p-/g; base-commit: cb96e1697ad6e54d11fc920c95f82977f8e438f8 -- gitgitgadget
