On Wed, May 21, 2025 at 09:26:50AM -0400, D. Ben Knoble wrote: > On Wed, May 21, 2025 at 3:56 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > > Signed-off-by: D. Ben Knoble <ben.knoble+github@xxxxxxxxx> > > > Helped-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > The order of these trailers should be reversed -- your SOB should always > > come last. > > Thanks; I didn't know that! (Aside: rebase --signoff seems to add SOB > even when it's already present. Is that a bug in rebase --signoff or a > misuse of the trailer on my end? Setting "trailer.ifExists = > addIfDifferent" didn't seem to affect it.) git-rebase(1) assumes that your SOB comes last, so that's probably why it re-adds it :) Patrick
