On Wed, May 21, 2025 at 3:56 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > On Tue, May 20, 2025 at 03:34:56PM -0400, D. Ben Knoble wrote: > > Going back to the introduction of the env parameter for the editor in > > 8babab95af (builtin-commit.c: export GIT_INDEX_FILE for launch_editor as > > well., 2007-11-26), we pass a constant array of strings: as the > > surrounding APIs evolved to use strvecs, the editor code did not. > > > > There is only one caller of all 3 editor APIs that does not pass a NULL > > environment (the same caller for which this parameter was added), and > > it already has a strvec available to use. > > Okay. It would've been nice to explain _why_ we want to do this change, > but the change itself looks sensible. Ah, yes. I think it's really just "cleanup" here—it started out as "maybe necessary prep for later work," and I kept it in this series. Will expand slightly in reroll. > > > Signed-off-by: D. Ben Knoble <ben.knoble+github@xxxxxxxxx> > > Helped-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > The order of these trailers should be reversed -- your SOB should always > come last. Thanks; I didn't know that! (Aside: rebase --signoff seems to add SOB even when it's already present. Is that a bug in rebase --signoff or a misuse of the trailer on my end? Setting "trailer.ifExists = addIfDifferent" didn't seem to affect it.) > > Patrick
