On Tue, 9 Sept 2025 at 18:50, Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Sep 09, 2025 at 04:25:58PM +0000, Shiva Subramanian wrote: > > Thank you, rather than chop and change these flags I decided to teach configure > > about the Nonstop platform (being eternally optimistic that we will make this > > port happen) so I was able to properly build without the PIC option and also > > get make to choose the newer malloc functions. > > > > Although, libiberty is still giving me trouble - I see in libiberty/Makefile.in > > that it needs to build choose-temp.c (a very small program) but there are no > > guards around mktemp, a deprecated function? I've hit a point where I have to > > hardcode a change. > > > > A comment in the code suggests that 'this function is provided for backwards > > compatibility only. Its use is not recommended.' but if our platform does not > > provide the deprecated function - how would we handle this? Would a change to > > this file be considered? To add macros around it so it doesn't fail? I > > understand this is all hypothetical but I want to know if I'm going in the > > right direction. > > mktemp() has a huge big toctou hole, mkstemp() is much preferred. But > if configure cannot find the more modern mkstemp(), it does check if > mktemp() does exist. It looks like libiberty/choose-temp.c always uses mktemp. So if the platform doesn't provide it at all, then that file will need some changes for the new target.
