On Tue, Sep 09, 2025 at 06:55:56PM +0100, Jonathan Wakely wrote: > On Tue, 9 Sept 2025 at 18:50, Segher Boessenkool > <segher@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Sep 09, 2025 at 04:25:58PM +0000, Shiva Subramanian wrote: > > mktemp() has a huge big toctou hole, mkstemp() is much preferred. But > > if configure cannot find the more modern mkstemp(), it does check if > > mktemp() does exist. > > It looks like libiberty/choose-temp.c always uses mktemp. Huh, it doesn't even try mkstemp() first? Wow. > So if the platform doesn't provide it at all, then that file will need > some changes for the new target. Yeah. Not just for *good* behaviour, but to work at all even! Segher
