On Tue, Aug 26, 2025 at 03:22:30PM +0200, Christoph Hellwig wrote: > On Mon, Aug 25, 2025 at 11:44:10PM +0800, Zorro Lang wrote: > > > Anyhow, failure to set up a dm-thinp volume sounds like failing to meet > > > a test precondition, sooo > > > > I'm wondering, if we choose _notrun when _dmthin_init/dmsetup_create fails, > > but others _dmxxxx_init/dmsetup_create [1] fails, we still call _fatal. Isn't > > that an inconsistent behavior :) > > I think more notrun would be fine. These are the ones I ran into > with a totally normal setup that has PI enabled on the test and > scratch devices, so they were my priority. OK, the patchset has been merged into patches-in-queue branch, will be pushed if no regression from it. If PI enabled devices don't support thinp related tests, you can exclude "thin" group. (But we might need to make sure that the "thin" group is added into all cases use _dmthin_init.) Thanks, Zorro >
